From 174c6431196df365a739519dbc7d8cb02cfa0980 Mon Sep 17 00:00:00 2001 From: campersau Date: Thu, 10 Feb 2022 09:55:31 +0100 Subject: [PATCH] PR feedback 1 --- src/SapNwRfc/Internal/Fields/DateField.cs | 12 ------------ src/SapNwRfc/Internal/Fields/DecimalField.cs | 4 ---- src/SapNwRfc/Internal/Fields/TimeField.cs | 12 ------------ 3 files changed, 28 deletions(-) diff --git a/src/SapNwRfc/Internal/Fields/DateField.cs b/src/SapNwRfc/Internal/Fields/DateField.cs index 9cd0a4a..fe62680 100644 --- a/src/SapNwRfc/Internal/Fields/DateField.cs +++ b/src/SapNwRfc/Internal/Fields/DateField.cs @@ -19,12 +19,7 @@ public DateField(string name, DateTime? value) public override void Apply(RfcInterop interop, IntPtr dataHandle) { -#if NETSTANDARD2_0 char[] buffer = (Value?.ToString(RfcDateFormat, CultureInfo.InvariantCulture) ?? ZeroRfcDateString).ToCharArray(); -#else - char[] buffer = ZeroRfcDateString.ToCharArray(); - Value?.TryFormat(buffer, out var _, RfcDateFormat, CultureInfo.InvariantCulture); -#endif RfcResultCode resultCode = interop.SetDate( dataHandle: dataHandle, @@ -47,17 +42,10 @@ public static DateField Extract(RfcInterop interop, IntPtr dataHandle, string na resultCode.ThrowOnError(errorInfo); -#if NETSTANDARD2_0 string dateString = new string(buffer); if (dateString == EmptyRfcDateString || dateString == ZeroRfcDateString) return new DateField(name, null); -#else - Span dateString = buffer.AsSpan(); - - if (dateString.SequenceEqual(EmptyRfcDateString) || dateString.SequenceEqual(ZeroRfcDateString)) - return new DateField(name, null); -#endif if (!DateTime.TryParseExact(dateString, RfcDateFormat, CultureInfo.InvariantCulture, DateTimeStyles.None, out DateTime date)) return new DateField(name, null); diff --git a/src/SapNwRfc/Internal/Fields/DecimalField.cs b/src/SapNwRfc/Internal/Fields/DecimalField.cs index 6ebca79..587e3c7 100644 --- a/src/SapNwRfc/Internal/Fields/DecimalField.cs +++ b/src/SapNwRfc/Internal/Fields/DecimalField.cs @@ -54,11 +54,7 @@ public static DecimalField Extract(RfcInterop interop, IntPtr dataHandle, string resultCode.ThrowOnError(errorInfo); -#if NETSTANDARD2_0 var decimalValue = decimal.Parse(new string(buffer, 0, (int)stringLength), CultureInfo.InvariantCulture); -#else - var decimalValue = decimal.Parse(buffer.AsSpan(), provider: CultureInfo.InvariantCulture); -#endif return new DecimalField(name, decimalValue); } diff --git a/src/SapNwRfc/Internal/Fields/TimeField.cs b/src/SapNwRfc/Internal/Fields/TimeField.cs index dc1ffb3..efa0ee0 100644 --- a/src/SapNwRfc/Internal/Fields/TimeField.cs +++ b/src/SapNwRfc/Internal/Fields/TimeField.cs @@ -19,12 +19,7 @@ public TimeField(string name, TimeSpan? value) public override void Apply(RfcInterop interop, IntPtr dataHandle) { -#if NETSTANDARD2_0 char[] buffer = (Value?.ToString(RfcTimeFormat, CultureInfo.InvariantCulture) ?? ZeroRfcTimeString).ToCharArray(); -#else - char[] buffer = ZeroRfcTimeString.ToCharArray(); - Value?.TryFormat(buffer, out var _, RfcTimeFormat, CultureInfo.InvariantCulture); -#endif RfcResultCode resultCode = interop.SetTime( dataHandle: dataHandle, @@ -47,17 +42,10 @@ public static TimeField Extract(RfcInterop interop, IntPtr dataHandle, string na resultCode.ThrowOnError(errorInfo); -#if NETSTANDARD2_0 string timeString = new string(buffer); if (timeString == EmptyRfcTimeString || timeString == ZeroRfcTimeString) return new TimeField(name, null); -#else - Span timeString = buffer.AsSpan(); - - if (timeString.SequenceEqual(EmptyRfcTimeString) || timeString.SequenceEqual(ZeroRfcTimeString)) - return new TimeField(name, null); -#endif if (!TimeSpan.TryParseExact(timeString, RfcTimeFormat, CultureInfo.InvariantCulture, out TimeSpan time)) return new TimeField(name, null);