Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 - Laying the foundation for the button components #1879

Open
branlok opened this issue Jun 20, 2022 · 0 comments
Open

V4 - Laying the foundation for the button components #1879

branlok opened this issue Jun 20, 2022 · 0 comments

Comments

@branlok
Copy link
Contributor

branlok commented Jun 20, 2022

Hello,
Like to make a proposal to expand a bit on the component for v4 button component as part of laying the foundation for the future. All observable styles in v3 (and more as v4 expands) will have the styling logic be included in the component by passing the required and optional props. Abstracting and encapsulating a range of styles can safe guard against developer's altering brand design consistency. While it's still possible to cascade styles from parent component, the constraints should make it become the last resort.

Figma link serves as a visual proposal and examples for the few button types and customizability + additional reasoning.
https://www.figma.com/file/zaPBj1kYY7bZ7NTC3HDnkU/Kitsu-Buttons?node-id=10%3A286

I can implement something for review, but if things are already set in stone, it's okay too.

@branlok branlok mentioned this issue Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant