Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with mocha 10 #429

Closed
birtles opened this issue May 2, 2022 · 1 comment
Closed

Incompatible with mocha 10 #429

birtles opened this issue May 2, 2022 · 1 comment

Comments

@birtles
Copy link

birtles commented May 2, 2022

Describe the bug
After upgrading to mocha 10, playwright-test fails with:

Error: R] Could not resolve "mocha/mocha-es2018.js"

    node_modules/playwright-test/src/setup-mocha.js:6:18:
      6 │ import mocha from 'mocha/mocha-es2018.js'
        ╵                   ~~~~~~~~~~~~~~~~~~~~~~~

It looks like the mocha-es2018.js artifact was dropped in mochajs/mocha@70fe3ad as part of mochajs/mocha#4848.

I guess we should just use mocha.js but I wonder if there was a reason for using mocha-es2018.js in the first place?

@hugomrdias
Copy link
Owner

Should be fixed in v8, thank you for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants