New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataCloneError in Safari/WebKit #3
Comments
Fixed in v0.3.2 |
@hughfenghen thanks, I can confirm this solution is working in Safari. However, the sourcemap for worker is triggering a console issue in Safari (screenshot below) and Firefox is not able to find it. This is only a minor discomfort during local development and from my perspective sourcemaps might be not generated. Since the main problem is solved I would normally close the issue but I leave it to you to decide in case you would like to ask me to verify something. Have a great day :) |
Unfortunately, this library doesn't work with WebKit. Maybe current implementation will work once this old bug is fixed but it is already years old: https://bugs.webkit.org/show_bug.cgi?id=215485
In our investigation with @czarsbenemoriendi we found that the root cause is in creation of FileHandle in main thread and then using postMessage to pass it to worker which WebKit cannot serialize. We checked a simple fix and moved FileHandle creation to worker and that was enough to solved the issue. But of course it has impact on the performance in the benchmark that is part of this repo.
We do not want to decide how to approach the issue according to the vision of opfs-tools but the rough solution might be verified here: Dev-Familia/opfs-tools@599f65f
Would be nice to know what solution will be pursed for this issue. Let us know if we could help here more. Thanks.
The text was updated successfully, but these errors were encountered: