Put all models in the constants #9170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative is to remove all content, but the previous state where one variable as some keys but the others not leads to failures. |
|
Yes, we really need to remove all of this @LysandreJik @thomwolf |
|
We do, but right now we still use them in the tests |
|
It was a bit confusing to me which to add in the constants and which not.. 😅 |
|
@sgugger one more small fix you can add is in tapas.rst under "Usage: inference", there should be one more space:
(Sorry, if I see more things I make a new PR myself :p) |
|
Pushing your fix on master directly Niels |
guyrosin
pushed a commit
to guyrosin/transformers
that referenced
this pull request
Jan 15, 2021
* Put all models in the constants * Add Google AI mention in the main README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It was impossible to use all pretrained checkpoints in the tapas tokenzier file because they were not in the constants of the file. This PR fixes that.