Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some warning for Dynamo and enable TF32 when it's set #20515

Merged
merged 1 commit into from Nov 30, 2022
Merged

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 30, 2022

What does this PR do?

This PR adds a warning when a user sets torchdynamo without an Ampere GPU (or higher) and also enables TF32 unless the user explicitly asked not it with --no_tf32 to get the best performance.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 30, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgugger sgugger merged commit e342ac7 into main Nov 30, 2022
@sgugger sgugger deleted the dynamo_tf32 branch November 30, 2022 20:42
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Dec 7, 2022
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
miyu386 pushed a commit to miyu386/transformers that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants