Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repurpose torchdynamo training args towards torch._dynamo #20498

Merged
merged 2 commits into from Nov 30, 2022
Merged

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 29, 2022

What does this PR do?

This PR re-uses the current torchdynamo training argument to be compatible with the internal module of PyTorch (in the nightlies). This is slightly breaking but at the same time the torchdynamo package has migrated to PyTorch proper, and the integration was marked as experimental.

The "fx2trt-fp16" backend is not advertised by PyTorch, so I removed it.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 29, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, LGTM! Surprised by the amount of dynamo backends!

@sgugger sgugger merged commit 08b4621 into main Nov 30, 2022
@sgugger sgugger deleted the dynamo_support branch November 30, 2022 16:10
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Dec 7, 2022
…e#20498)

* Repurpose torchdynamo training args towards torch._dynamo

* Add doc
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
…e#20498)

* Repurpose torchdynamo training args towards torch._dynamo

* Add doc
miyu386 pushed a commit to miyu386/transformers that referenced this pull request Feb 9, 2023
…e#20498)

* Repurpose torchdynamo training args towards torch._dynamo

* Add doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants