Skip to content

Fix minimum version for device_map #20489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Fix minimum version for device_map #20489

merged 1 commit into from
Nov 30, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 29, 2022

What does this PR do?

Turns out it all works fine with PyTorch 1.10 which contains torch.cuda.mem_get_info used by Accelerate (but this isn't in the documentation of PyTorch 1.10).

Verified

This commit was signed with the committer’s verified signature.
sgugger Sylvain Gugger
@sgugger sgugger requested a review from LysandreJik November 29, 2022 14:41
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 29, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sgugger sgugger merged commit 396a6a2 into main Nov 30, 2022
@sgugger sgugger deleted the version_check_bis branch November 30, 2022 16:10
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants