Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table transformer [v2] #19614

Merged
merged 14 commits into from Oct 18, 2022

Conversation

NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Oct 14, 2022

What does this PR do?

This PR adds Table Transformer by Microsoft, as a separate model, rather than tweaking the existing DETR implementation.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this new model!

New model additions are very big PRs on their own, so let's remove the non-related stuff in another PR please.

docs/source/en/_toctree.yml Outdated Show resolved Hide resolved
docs/source/en/model_doc/deformable_detr.mdx Outdated Show resolved Hide resolved
src/transformers/models/detr/modeling_detr.py Outdated Show resolved Hide resolved
@NielsRogge
Copy link
Contributor Author

NielsRogge commented Oct 17, 2022

@sgugger I've removed the non-Table Transformer related stuff to #19644 ;)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 17, 2022

The documentation is not available anymore as the PR was closed or merged.

@NielsRogge
Copy link
Contributor Author

@sgugger PR is ready, feel free to approve :)

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for working on this model!

@NielsRogge NielsRogge merged commit dd523da into huggingface:main Oct 18, 2022
kashif pushed a commit to kashif/transformers that referenced this pull request Oct 21, 2022
* First draft

* Add conversion script

* Make conversion work

* Upload checkpoints

* Add final fixes

* Revert changes of conditional and deformable detr

* Fix toctree, add and remove copied from

* Use model type

* Improve docs

* Improve code example

* Update copies

* Add copied formt

* Don't update conditional detr

* Don't update deformable detr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants