Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whisper for pipeline #19482

Merged
merged 7 commits into from Oct 11, 2022

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

After the merge of #19378 , the feature extractor does not work with the pipeline function. This PR is the same as #19385.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 11, 2022

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

Before we merge here, let's try to have the following tests working:

@ArthurZucker
Copy link
Collaborator Author

We were missing a _CHECKPOINT_FOR_DOC, so I added a warning when the tests are skipped.
It seems a little bit problematic as if it is unused, quality will fail (and in our case, I had to change the code to use it 😃 )
Other models that are not tested :
SpeechEncoderDecoderModel, Speech2TextForConditionalGeneration, which are also just missing the _CHECKPOINT_FOR_DOC(see here )

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit b722a6b into huggingface:main Oct 11, 2022
sgugger pushed a commit that referenced this pull request Oct 11, 2022
* update feature extractor params

* update attention mask handling

* fix doc and pipeline test

* add warning when skipping test

* add whisper translation and transcription test

* fix build doc test
@ArthurZucker ArthurZucker deleted the fix-whisper-for-pipeline branch October 11, 2022 13:00
ajsanjoaquin pushed a commit to ajsanjoaquin/transformers that referenced this pull request Oct 12, 2022
* update feature extractor params

* update attention mask handling

* fix doc and pipeline test

* add warning when skipping test

* add whisper translation and transcription test

* fix build doc test
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 18, 2022
* update feature extractor params

* update attention mask handling

* fix doc and pipeline test

* add warning when skipping test

* add whisper translation and transcription test

* fix build doc test
kashif pushed a commit to kashif/transformers that referenced this pull request Oct 21, 2022
* update feature extractor params

* update attention mask handling

* fix doc and pipeline test

* add warning when skipping test

* add whisper translation and transcription test

* fix build doc test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants