Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FlaubertTokenizer.__init__ #19469

Merged
merged 1 commit into from Oct 10, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Oct 10, 2022

What does this PR do?

There was a tiny error in #19330

do_lowercase=do_lowercase**kwargs,

@@ -261,7 +261,8 @@ def __init__(
lang2id=lang2id,
id2lang=id2lang,
do_lowercase_and_remove_accent=do_lowercase_and_remove_accent,
do_lowercase=do_lowercase**kwargs,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some errors

E           TypeError: unsupported operand type(s) for ** or pow(): 'bool' and 'dict'

@ydshieh ydshieh requested a review from sgugger October 10, 2022 17:03
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 10, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LysandreJik LysandreJik merged commit a7bc422 into huggingface:main Oct 10, 2022
ajsanjoaquin pushed a commit to ajsanjoaquin/transformers that referenced this pull request Oct 12, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 18, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
kashif pushed a commit to kashif/transformers that referenced this pull request Oct 21, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants