Wrap FlauBERT integration test forward passes with torch.no_grad() #19412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
approved these changes
Oct 10, 2022
ajsanjoaquin
pushed a commit
to ajsanjoaquin/transformers
that referenced
this pull request
Oct 12, 2022
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 18, 2022
kashif
pushed a commit
to kashif/transformers
that referenced
this pull request
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR wraps forward passes in FlauBERT integration tests with
torch.no_grad(), as proposed in issue #14642. This avoids the computation of unnecessary gradients during inference.Before submitting
Who can review?
@LysandreJik could you please take a look at it?
Thanks :)