[fix] Add DeformableDetrFeatureExtractor #19140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
commented
Sep 21, 2022
|
|
||
| return encoded_inputs | ||
|
|
||
| def post_process(self, outputs, target_sizes): |
There was a problem hiding this comment.
FYI, this is the only difference with DETR's feature extractor.
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
Sep 21, 2022
src/transformers/models/deformable_detr/modeling_deformable_detr.py
Outdated
Show resolved
Hide resolved
tests/models/deformable_detr/test_feature_extraction_deformable_detr.py
Outdated
Show resolved
Hide resolved
src/transformers/models/deformable_detr/feature_extraction_deformable_detr.py
Outdated
Show resolved
Hide resolved
src/transformers/models/deformable_detr/feature_extraction_deformable_detr.py
Outdated
Show resolved
Hide resolved
src/transformers/models/deformable_detr/feature_extraction_deformable_detr.py
Outdated
Show resolved
Hide resolved
sgugger
approved these changes
Sep 21, 2022
NielsRogge
force-pushed
the
deformable_detr_patch
branch
from
f52e104
to
038328d
Compare
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
* Add DeformableDetrFeatureExtractor * Fix post_process * Fix name * Add tests for feature extractor * Fix doc tests * Fix name * Address comments * Apply same fix to DETR and YOLOS as well Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As pointed out by @DeppMeng who is adding Conditional DETR in #18948, the postprocessing of Deformable DETR is actually different compared to regular DETR. Namely, a sigmoid activation function is used rather than softmax, and the no-object class is included, whereas DETR discards this class.
Hence, we'll need a new
DeformableDetrFeatureExtractorwhich includes this custom postprocessing logic. As only the postprocessing of object detection is different, I'm usingCopied fromstatements wherever possible.To do:
preprocessor_config.jsonof all repos on the hubfrom_pretrainedin the code snippets for the feature extractor