Re-add support for single url files in objects download #19014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
approved these changes
Sep 13, 2022
|
cc @alaradirik |
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
added a commit
that referenced
this pull request
Sep 13, 2022
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
During the cache revamp done in #18438, we accidentally lost support for single urls in
from_pretrainedmethods (something likeconfig = AutoConfig.from_pretrained("http://my_custom_config.json"). This is not something we want to support in the long run as users should use the Hub to store their objects, but this is still a breaking change.This PR adds support for this corner case with proper deprecation warnings. Note that such urls are not cached anymore.