Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MaskFormerFeatureExtractor instance segmentation preprocessing bug #18997

Merged
merged 4 commits into from Sep 13, 2022
Merged

Fix MaskFormerFeatureExtractor instance segmentation preprocessing bug #18997

merged 4 commits into from Sep 13, 2022

Conversation

alaradirik
Copy link
Contributor

@alaradirik alaradirik commented Sep 12, 2022 •
edited

What does this PR do?

  • Updates MaskFormerFeatureExtractor docstrings for clarity
  • Fixes bug in MaskFormerFeatureExtractor that causes instance segmentation maps to be processed incorrectly
  • Adds support to use per-image instance_id_2_semantic_id mappings

Fixes #18989

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ X] Did you read the contributor guideline,
    Pull Request section?
  • [X ] Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • [X ] Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@alaradirik alaradirik changed the title Maskformer preprocessor fix Fix MaskFormerFeatureExtractor instance segmentation preprocessing bug Sep 12, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 12, 2022 •
edited

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@alaradirik alaradirik merged commit 69df33f into huggingface:main Sep 13, 2022
sgugger pushed a commit that referenced this pull request Sep 13, 2022
@alaradirik @sgugger
Fix MaskFormerFeatureExtractor instance segmentation preprocessing bug (
c6415fa 
#18997)

* fix preprocessing for instance segmentation maps

* add support for per-image instance2class_id mapping

* edit docstrings for clarity
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
@alaradirik @oneraghavan
Fix MaskFormerFeatureExtractor instance segmentation preprocessing bug (
c99b524 
huggingface#18997)

* fix preprocessing for instance segmentation maps

* add support for per-image instance2class_id mapping

* edit docstrings for clarity
@NielsRogge NielsRogge mentioned this pull request Nov 7, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@NielsRogge NielsRogge Awaiting requested review from NielsRogge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MaskFormerFeatureExtractor doesn't process instance segmentation maps correctly
3 participants
@alaradirik @HuggingFaceDocBuilderDev @sgugger