Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF: TF 2.10 unpin + related onnx test skips #18995

Merged
merged 2 commits into from Sep 12, 2022
Merged

Conversation

gante
Copy link
Member

@gante gante commented Sep 12, 2022

What does this PR do?

Unpins TF, but adds the appropriate test skips.

Should remove the tensorflow probability CI problem.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 12, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gante .

I see you also added 2 CMD ["/bin/bash"]. I think it will be fine - some commands may or may not work on different shells though. I personally would prefer to work with bash too.

@gante
Copy link
Member Author

gante commented Sep 12, 2022

@ydshieh -- no command was added there, but rather a newline at the end of the file (automatic vscode settings). They already exist in some of the docker files. Happy to revert!

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 12, 2022

Oh, it's fine. No need to revert. (The consequence of getting up at 5AM ...)

@gante gante merged commit 1182b94 into huggingface:main Sep 12, 2022
@gante gante deleted the tf_210 branch September 12, 2022 18:30
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants