Fix Sylvain's nits on the original KerasMetricCallback PR #18300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocketknight1
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Jul 26, 2022
src/transformers/keras_callbacks.py
Outdated
Comment on lines
66
to
68
| predict_with_generate (`bool`, *optional*, defaults to `False`): | ||
| predict_with_generate (`bool`, defaults to `False`): | ||
| Whether we should use `model.generate()` to get outputs for the model. | ||
| use_xla_generation (`bool`, *optional*, defaults to `False`): |
There was a problem hiding this comment.
The optional should still be there in the docstring because the argument is optional in the sense it has a default value. It's just the type annotation Optional (which means Union None) that wasn't correct ;-)
There was a problem hiding this comment.
Ah, I never knew that was our rule for writing docstrings! Fixing.
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
…e#18300) * Fix Sylvain's nits on the original PR * Update src/transformers/keras_callbacks.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Re-add "optional" to docstring Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.