New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EncoderDecoder] Improve docs #18271
Merged
NielsRogge
merged 3 commits into
huggingface:main
from
NielsRogge:improve_encoder_decoder_docs
Jul 27, 2022
Merged
[EncoderDecoder] Improve docs #18271
NielsRogge
merged 3 commits into
huggingface:main
from
NielsRogge:improve_encoder_decoder_docs
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for expanding the doc!
patrickvonplaten
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only checked the speech part - looks very nice!
NielsRogge
force-pushed
the
improve_encoder_decoder_docs
branch
from
July 27, 2022 07:51
8b27292
to
5e17209
Compare
LysandreJik
pushed a commit
that referenced
this pull request
Jul 27, 2022
* Improve docs * Improve docs of speech one as well * Apply suggestions from code review Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
* Improve docs * Improve docs of speech one as well * Apply suggestions from code review Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As a follow-up of #17815, this PR improves the docs of
VisionEncoderDecoderModel
andSpeechEncoderDecoderModel
.It also fixes some typos in the docs of
EncoderDecoderModel
.