Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EncoderDecoder] Improve docs #18271

Merged
merged 3 commits into from Jul 27, 2022

Conversation

NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Jul 23, 2022

What does this PR do?

As a follow-up of #17815, this PR improves the docs of VisionEncoderDecoderModel and SpeechEncoderDecoderModel.

It also fixes some typos in the docs of EncoderDecoderModel.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 23, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expanding the doc!

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only checked the speech part - looks very nice!

@NielsRogge NielsRogge force-pushed the improve_encoder_decoder_docs branch from 8b27292 to 5e17209 Compare July 27, 2022 07:51
@NielsRogge NielsRogge merged commit ccd4180 into huggingface:main Jul 27, 2022
LysandreJik pushed a commit that referenced this pull request Jul 27, 2022
* Improve docs

* Improve docs of speech one as well

* Apply suggestions from code review

Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Improve docs

* Improve docs of speech one as well

* Apply suggestions from code review

Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants