New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PYTEST_TIMEOUT for CircleCI test jobs #18251
Add PYTEST_TIMEOUT for CircleCI test jobs #18251
Conversation
d953683
to
6a37404
Compare
The documentation is not available anymore as the PR was closed or merged. |
I like the idea of getting a hard error instead of silently getting new tests that slow down the CI by quite a lot! Now we just ahve to get to all tests passing below that threshold 😅 |
Currently set to
and
This makes it difficult to determine a good threshold that won't be flaky. Current longest 2 tests(observed on a CircleCI workflow run):
|
b94f35b
to
b2407bc
Compare
setup.py
Outdated
@@ -139,7 +139,8 @@ | |||
"pytest", | |||
"pytest-timeout", | |||
"pytest-xdist", | |||
"python>=3.7.0", | |||
# To run the full tests -> This will be reverted. | |||
"python>=3.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will revert this line once this PR being approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reverted the change in |
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
Add
PYTEST_TIMEOUT: 30
for CircleCI jobs:The main goal is to avoid CircleCI's default 10 minute timeout that cancels the jobs. Also with this PR, we can see clearly which test (s) timeout.