Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] image classification example requires newer datasets version #17719

Merged
merged 1 commit into from Jun 15, 2022
Merged

Conversation

jeffra
Copy link
Contributor

@jeffra jeffra commented Jun 15, 2022

What does this PR do?

The DeepSpeed + Transformers integration tests are showing issues with this example. We install datastes >= 1.8.0 in the requirements.txt for this example. However, in running the example it requires datasets.Image() which wasn't introduced in datasets until 1.17.0 (as far as I can tell). This PR bumps up the min version to one that works with the example.

Example output showing the error: https://github.com/microsoft/DeepSpeed/runs/6869668978?check_suite_focus=true

We also are seeing issues with some of the examples with the latest datasets release but will file a different issue for that.

/cc @mrwyattii

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stas00, @sgugger

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Jeff!

@stas00 stas00 requested a review from sgugger June 15, 2022 16:46
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 15, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit 6ebeeee into huggingface:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants