Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change push CI to run on workflow_run event" #17717

Merged
merged 1 commit into from Jun 15, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 15, 2022

Reverts #17692

Really sorry, but the notification_service.py has error

Traceback (most recent call last):
  File "utils/notification_service.py", line 766, in <module>
    ci_author = ci_details["author"]["login"]
KeyError: 'author'

as the GH event is no longer coupled with a commit, and we lose some information about commit/author.
I need to change more things.

(On my own repo for testing, there is no notification_service.py. And this change of workflow_run can only be verified when being merged to main)

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope to have it back soon 😢

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 15, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Jun 15, 2022

merged to avoid further test failures

@ydshieh ydshieh merged commit 50415b8 into main Jun 15, 2022
@ydshieh ydshieh deleted the revert-17692-push_ci_on_workflow_run branch June 15, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants