Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wav2Vec2Conformer] Official release #17709

Conversation

patrickvonplaten
Copy link
Contributor

What does this PR do?

Add link to paper and improve readme

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 15, 2022

The documentation is not available anymore as the PR was closed or merged.

@sgugger
Copy link
Collaborator

sgugger commented Jun 15, 2022

Wait, how was the repo-consistency check passing without this? It should have given a big red cross.

@patrickvonplaten
Copy link
Contributor Author

Wait, how was the repo-consistency check passing without this? It should have given a big red cross.

What is the problem here exactly?

@sgugger
Copy link
Collaborator

sgugger commented Jun 15, 2022

There is a check in the CI that shouldn't let models be present without being in the README, I was wondering why it was not failing but found the reason. Wav2Vec2-Conformer is whitelisted for this test. Could you remove it from MODELS_NOT_IN_README in utils/check_copies.py in this PR?

@patrickvonplaten
Copy link
Contributor Author

I see - will do!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@patrickvonplaten patrickvonplaten merged commit 7f14839 into huggingface:main Jun 15, 2022
@patrickvonplaten patrickvonplaten deleted the make_conformer_wav2vec2_official branch June 15, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants