Change push CI to run on workflow_run event #17692
Conversation
ydshieh
force-pushed
the
push_ci_on_workflow_run
branch
from
d3409f2
to
217612f
Compare
|
The documentation is not available anymore as the PR was closed or merged. |
| @@ -13,17 +14,8 @@ on: | |||
|
|
|||
| jobs: | |||
There was a problem hiding this comment.
Can't comment above, bu I think we need a workflow_dispatch: under the on: above.
There was a problem hiding this comment.
workflow_dispatch is used to trigger a workflow manually:
To manually trigger a workflow, use the workflow_dispatch event. You can manually trigger a workflow run using the GitHub API, GitHub CLI, or GitHub browser interface.
(doc)
And this is not in our original push-CI workflow file. I checked the current logic in my own dummy repo., and things work as expected (of course, without the huge chunk of test jobs in transformers.)
Let me know if you have other considerations for adding workflow_dispatch, thanks.
There was a problem hiding this comment.
Ok, this looks good to me! Thanks for taking care of fixing it @ydshieh, I can't wait to see it run and see how it works :)
|
@sgugger I merged this PR, you can check on the commit history page Change push CI to run on workflow_run event Hope you ❤️ it! |
|
Amazing, thanks a lot! |
|
I am sorry to bother you again ... |
What does this PR do?
The attempt in #17369 (to make commit history status checks less noisy) unfortunately has no effect.
After a discussion in this comment, this PR changes push CI to be triggered by a
on: workflow_runevent.Note the change only takes effect once this PR is merged into
main, as mentioned in the doc. of workflow_run.The result would be like in accelerate, where the jobs in
on-merge.ymlwon't be shown, and the workflow run page look like this.