Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: RemBERT fixes #17641

Merged
merged 3 commits into from Jun 15, 2022
Merged

Documentation: RemBERT fixes #17641

merged 3 commits into from Jun 15, 2022

Conversation

stefan-it
Copy link
Collaborator

@stefan-it stefan-it commented Jun 9, 2022

Hi,

this PR introduces some fixes for the RemBERT documentation:

Python Codeblock fix for the configuration class. It is currently broken:

image

And now fixed with this PR:

image

See here for live demo.

Additionally, the model identifier rembert is not working, because the model is stored under the google namespace. This fix was done passing google/rembert to the checkpoint argument of the add_code_sample_docstrings decorator. This was reported in #17147.

Old model identifier example vs. new working model identifier example.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 9, 2022

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

Good catch!

@patrickvonplaten
Copy link
Contributor

Thanks for fixing @stefan-it

@patrickvonplaten patrickvonplaten merged commit 242cc6e into huggingface:main Jun 15, 2022
@stefan-it stefan-it deleted the rembert-doc-fixes branch June 15, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants