Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Spanish translation of fast_tokenizers.mdx #16882

Merged
merged 9 commits into from May 12, 2022
Merged

Documentation: Spanish translation of fast_tokenizers.mdx #16882

merged 9 commits into from May 12, 2022

Conversation

jloayza10
Copy link
Contributor

What does this PR do?

Fixes #15947
Translation to Spanish of fast_tokenizers.mdx

Before submitting

@omarespejel
Copy link
Contributor

Thank you @jloayza10! Could you please add fast_tokenizers to transformers/docs/source/es/_toctree.yml? As a reference, you can use the new Translation guide (section "✍️ Start translating"). This would allow the tests to pass.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 3, 2022 •
edited

The documentation is not available anymore as the PR was closed or merged.

@jloayza10
Copy link
Contributor Author

Hi @omarespejel , I added fast_tokenizers to the _toctree.yml file.
There is still a check_code_quality check that is failing, are there further modifications on my part to perform to address this or is this ok?

omarespejel
omarespejel suggested changes May 4, 2022
View reviewed changes
docs/source/es/fast_tokenizers.mdx Outdated Show resolved Hide resolved
docs/source/es/fast_tokenizers.mdx Outdated Show resolved Hide resolved
docs/source/es/fast_tokenizers.mdx Outdated Show resolved Hide resolved
docs/source/es/fast_tokenizers.mdx Outdated Show resolved Hide resolved
docs/source/es/fast_tokenizers.mdx Outdated Show resolved Hide resolved
docs/source/es/fast_tokenizers.mdx Outdated Show resolved Hide resolved
jloayza10 and others added 6 commits May 4, 2022 12:32
@jloayza10 @omarespejel
Update docs/source/es/fast_tokenizers.mdx
ca22b95 
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@jloayza10 @omarespejel
Update docs/source/es/fast_tokenizers.mdx
9e01f10 
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@jloayza10 @omarespejel
Update docs/source/es/fast_tokenizers.mdx
436ff28 
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@jloayza10 @omarespejel
Update docs/source/es/fast_tokenizers.mdx
475a656 
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@jloayza10 @omarespejel
Update docs/source/es/fast_tokenizers.mdx
7c9be50 
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@jloayza10 @omarespejel
Update docs/source/es/fast_tokenizers.mdx
9a66e6d 
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@omarespejel omarespejel merged commit e2d678b into huggingface:main May 12, 2022
@omarespejel
Copy link
Contributor

Thank you very much @jloayza10! This was great. Please let me know if you would like to translate another file 🤗

Narsil pushed a commit to Narsil/transformers that referenced this pull request May 12, 2022
@jloayza10 @omarespejel @Narsil
Documentation: Spanish translation of fast_tokenizers.mdx (huggingfac…
e9319a5 
…e#16882)

* Spanish translation of fast_tokenizers.mdx

* add fast_tokenizers to the spanish _toctree.yml

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
ArthurZucker pushed a commit to ArthurZucker/transformers that referenced this pull request May 12, 2022
@jloayza10 @omarespejel @ArthurZucker
Documentation: Spanish translation of fast_tokenizers.mdx (huggingfac…
afddbb2 
…e#16882)

* Spanish translation of fast_tokenizers.mdx

* add fast_tokenizers to the spanish _toctree.yml

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@jloayza10 jloayza10 deleted the spanish_doc_translation branch May 16, 2022 23:04
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@jloayza10 @omarespejel @elusenji
Documentation: Spanish translation of fast_tokenizers.mdx (huggingfac…
df64209 
…e#16882)

* Spanish translation of fast_tokenizers.mdx

* add fast_tokenizers to the spanish _toctree.yml

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

* Update docs/source/es/fast_tokenizers.mdx

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarespejel omarespejel omarespejel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tranformers documentation translation to Spanish
3 participants
@jloayza10 @omarespejel @HuggingFaceDocBuilderDev