New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegNet #16188

Merged

FrancescoSaverioZuppichini merged 51 commits into main from modeling_regnet

Apr 7, 2022

Contributor

FrancescoSaverioZuppichini commented Mar 16, 2022 •

edited

What does this PR do?

This WIP PR adds RegNet.

Currently, the model can be used as follows

from transformers import  RegNetConfig, RegNetForImageClassification
import requests
from io import BytesIO
res = requests.get('https://github.com/huggingface/transformers/blob/master/tests/fixtures/tests_samples/COCO/000000039769.png?raw=true')
image = Image.open(BytesIO(res.content))

feature_extractor = AutoFeatureExtractor.from_pretrained("zuppif/regnet-y-040")
model = RegNetForImageClassification.from_pretrained("zuppif/regnet-y-040").eval()

inputs = feature_extractor(image, return_tensors="pt")
outputs = model(**inputs)
print(model.config.id2label[torch.argmax(outputs.logits).item()])
# tiger cat

FrancescoSaverioZuppichini requested a review from NielsRogge

March 16, 2022 09:08

HuggingFaceDocBuilderDev commented Mar 16, 2022 •

edited

The documentation is not available anymore as the PR was closed or merged.

NielsRogge reviewed

View reviewed changes

docs/source/index.mdx Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

docs/source/model_doc/regnet.mdx Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

docs/source/model_doc/regnet.mdx Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

docs/source/model_doc/regnet.mdx Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/auto/configuration_auto.py Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/configuration_regnet.py Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/configuration_regnet.py Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/configuration_regnet.py Outdated

+                      depths (`List[int]`, *optional*, defaults to `[3, 4, 6, 3]`):
+                          Depth (number of layers) for each stage.
+                      layer_type (`str`, *optional*, defaults to `"bottleneck"`):
+                          The layer to use, it can be either `"x" or `"y"` (like `x` but with squeeze and excitation).

Contributor

NielsRogge Mar 16, 2022

Can you clarify this?

Contributor

NielsRogge Mar 16, 2022

What is x?

Contributor Author

FrancescoSaverioZuppichini Mar 16, 2022

updated the doc

Collaborator

sgugger Mar 16, 2022

The default needs to be update (it's "y" not "bottleneck") and what "x" and "y" mean should be detailed here in the docstring for people who did not read the paper.

Contributor Author

FrancescoSaverioZuppichini Mar 21, 2022

Updated, let me know if it is better

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/modeling_regnet.py Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/configuration_regnet.py Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

NielsRogge reviewed

View reviewed changes

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

sgugger approved these changes

View reviewed changes

Collaborator

sgugger left a comment

Thanks for working on this new model. I left a few comments, but it's in good shape to be merged.

docs/source/_toctree.yml Outdated Show resolved Hide resolved

src/transformers/models/regnet/configuration_regnet.py Outdated

+                      depths (`List[int]`, *optional*, defaults to `[3, 4, 6, 3]`):
+                          Depth (number of layers) for each stage.
+                      layer_type (`str`, *optional*, defaults to `"bottleneck"`):
+                          The layer to use, it can be either `"x" or `"y"` (like `x` but with squeeze and excitation).

Collaborator

sgugger Mar 16, 2022

The default needs to be update (it's "y" not "bottleneck") and what "x" and "y" mean should be detailed here in the docstring for people who did not read the paper.

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

src/transformers/models/regnet/modeling_regnet.py Show resolved Hide resolved

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

src/transformers/models/regnet/modeling_regnet.py Outdated Show resolved Hide resolved

FrancescoSaverioZuppichini force-pushed the modeling_regnet branch from f135aee to 4025d7d Compare

March 21, 2022 16:05

FrancescoSaverioZuppichini force-pushed the modeling_regnet branch 2 times, most recently from 94ce99b to 4ff7b1a Compare

March 31, 2022 08:16

Contributor Author

FrancescoSaverioZuppichini commented Mar 31, 2022

Updated the codebase to use config when is possible. I had to update ResNetModel as well to make make fixup happy :)

FrancescoSaverioZuppichini mentioned this pull request

Closed

1 task

sgugger reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

src/transformers/models/resnet/modeling_resnet.py Outdated Show resolved Hide resolved

FrancescoSaverioZuppichini force-pushed the modeling_regnet branch 2 times, most recently from 303c1a6 to 45319dd Compare

April 5, 2022 17:21

FrancescoSaverioZuppichini requested a review from NielsRogge

April 5, 2022 18:41

Contributor Author

FrancescoSaverioZuppichini commented Apr 5, 2022

Conversion script for the 10B regnet model added + needed changes inside PretrainedModel._load_pretrained_model_low_mem

FrancescoSaverioZuppichini and others added 26 commits

April 7, 2022 21:17


          minor changes

d316414


          minor changes

a8991a5


          minor changes

c87f49d


          minor changes

92019c4


          minor changes

d1df21e


          minor changes

23cf0eb


          minor changes

9469a0e


          minor changes

a8fc8e5


          minor changes

2fa391c


          minor changes


          minor changes

015c7f3


          hopefully a working conversion script

ca19860


          minor changes

3aab2f5


          minor changes

3b34639


          minor changes

f1bbf4f


          to the moon

b40eb17


          minor changes

bfd02a4


          removed temp dir for 10b model

ca22ffe


          token as env otherwise I can't run it in docker

c5b914a


          fixed for 10b model

04e17b8


          minor updates in the doc + make style

c387847


          removed unused code

c499a45


          Apply suggestions from code review

Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>


          removed unused code

c6e0551


          removed unused code

bf40ce9


          updated modeling_utils from main

fa5506e

FrancescoSaverioZuppichini force-pushed the modeling_regnet branch from 123096e to fa5506e Compare

April 7, 2022 19:17

Contributor Author

FrancescoSaverioZuppichini commented Apr 7, 2022 •

edited

Thanks to all reviewers, I've rebased and updated the code accordingly

FrancescoSaverioZuppichini merged commit af14c61 into main

FrancescoSaverioZuppichini deleted the modeling_regnet branch

April 7, 2022 19:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment