Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing empty prompts for text-generation when BOS exists. #13859

Merged
merged 3 commits into from Oct 5, 2021
Merged

Fixing empty prompts for text-generation when BOS exists. #13859

merged 3 commits into from Oct 5, 2021

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Oct 4, 2021

What does this PR do?

Fixes #13774

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@LysandreJik

LysandreJik
LysandreJik approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you for working on this @Narsil!

@LysandreJik
Copy link
Member

It seems there is an issue with the TensorFlow pipeline tests

@Narsil Narsil merged commit 3a9c0f2 into huggingface:master Oct 5, 2021
stas00 pushed a commit to stas00/transformers that referenced this pull request Oct 12, 2021
@Narsil @stas00
Fixing empty prompts for text-generation when BOS exists. (huggingfac…
da3091b 
…e#13859)

* Fixing empty prompts for text-generation when BOS exists.

* Fixing odd case with Pegasus.

* Fixing Bert is Assertion Error.
lapisfluvialis pushed a commit to lapisfluvialis/transformers that referenced this pull request Oct 27, 2021
@Narsil @LysandreJik
Fixing empty prompts for text-generation when BOS exists. (huggingfac…
a8186b0 
…e#13859)

* Fixing empty prompts for text-generation when BOS exists.

* Fixing odd case with Pegasus.

* Fixing Bert is Assertion Error.
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
@Narsil
Fixing empty prompts for text-generation when BOS exists. (huggingfac…
9112723 
…e#13859)

* Fixing empty prompts for text-generation when BOS exists.

* Fixing odd case with Pegasus.

* Fixing Bert is Assertion Error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty prompts failing in dev sources
2 participants
@Narsil @LysandreJik