Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wav2Vec2] Better error message #13777

Merged
merged 1 commit into from Sep 29, 2021
Merged

[Wav2Vec2] Better error message #13777

merged 1 commit into from Sep 29, 2021

Conversation

patrickvonplaten
Copy link
Contributor

What does this PR do?

Better error messsage when a model with lm head is initialized from a pretranied model.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten linked an issue Sep 28, 2021 that may be closed by this pull request
Pretrained Wav2Vec2 Model large robust does not load #13775
Closed
@patrickvonplaten patrickvonplaten requested review from sgugger, LysandreJik and anton-l and removed request for LysandreJik September 28, 2021 14:34
sgugger
sgugger approved these changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

anton-l
anton-l approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thank you!

@patrickvonplaten patrickvonplaten merged commit aa018a7 into huggingface:master Sep 29, 2021
@patrickvonplaten patrickvonplaten deleted the add_better_error_message_wav2vec2 branch September 29, 2021 08:30
stas00 pushed a commit to stas00/transformers that referenced this pull request Oct 12, 2021
@patrickvonplaten @stas00
up (huggingface#13777)
4e8d21e
lapisfluvialis pushed a commit to lapisfluvialis/transformers that referenced this pull request Oct 27, 2021
@patrickvonplaten @sgugger
up (huggingface#13777)
11144a3
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
@patrickvonplaten
up (huggingface#13777)
7ea97d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-l anton-l anton-l approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pretrained Wav2Vec2 Model large robust does not load
3 participants
@patrickvonplaten @anton-l @sgugger