Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning for gradient_checkpointing #13767

Merged
merged 1 commit into from Sep 28, 2021
Merged

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Sep 27, 2021

What does this PR do?

The default value in #13734 was in the wrong direction 🤦‍♂️ This PR fixes that.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM! Should a patch release be done for that?

@LysandreJik LysandreJik merged commit 83d3dc0 into master Sep 28, 2021
@LysandreJik LysandreJik deleted the fix_warning_gradient branch September 28, 2021 18:21
stas00 pushed a commit to stas00/transformers that referenced this pull request Oct 12, 2021
lapisfluvialis pushed a commit to lapisfluvialis/transformers that referenced this pull request Oct 27, 2021
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants