Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LayoutLM ONNX test error #13710

Merged
merged 4 commits into from Sep 29, 2021

Conversation

nishprabhu
Copy link
Contributor

What does this PR do?

Fixes the batch_size and seq_len computation during ONNX export in configuration_layoutlm.py.

PRs: #13702, #13562
Issue: #13300

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@michaelbenayoun @LysandreJik @NielsRogge @mfuntowicz

@NielsRogge
Copy link
Contributor

Hi,

Can you also add LayoutLM to the list of supported models? https://huggingface.co/transformers/serialization.html

Thanks!

@michaelbenayoun
Copy link
Member

Seems good to me!

@NielsRogge I think he has already done it, or you're talking about something different?

@NielsRogge
Copy link
Contributor

NielsRogge commented Sep 28, 2021

Yeah I'm talking about the documentation (.rst file): https://github.com/huggingface/transformers/blob/master/docs/source/serialization.rst

It also seems like other models (like mBART) are supported to be exported to ONNX, but they are not mentioned in the docs. I asked @sgugger if we can create an automagically updated table for this.

@nishprabhu
Copy link
Contributor Author

nishprabhu commented Sep 29, 2021

@NielsRogge I have added LayoutLM to the list of supported models. :)

@michaelbenayoun michaelbenayoun merged commit a1ea3ad into huggingface:master Sep 29, 2021
stas00 pushed a commit to stas00/transformers that referenced this pull request Oct 12, 2021
lapisfluvialis pushed a commit to lapisfluvialis/transformers that referenced this pull request Oct 27, 2021
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 13, 2022
Albertobegue pushed a commit to Albertobegue/transformers that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants