Fixing #13381 #13400
Merged
Fixing #13381 #13400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
reviewed
Sep 6, 2021
Comment on lines
+125
to
+130
| if "too short" in str(e): | ||
| # tokenizers might yell that we want to truncate | ||
| # to a value that is not even reached by the input. | ||
| # In that case we don't want to truncate. | ||
| # It seems there's not a really better way to catch that | ||
| # exception. |
There was a problem hiding this comment.
Could you provide a reproducer for this issue? I can't seem to find where that would come from
There was a problem hiding this comment.
Basic test for the pipelines RUN_PIPELINE_TESTS=1 pytest -sv tests/test_pipelines_zero_shot_classification.py will do (on the LED test)
LysandreJik
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Indeed, the error comes directly from the tokenizers library so there's not much we can do about it here. LGTM, thanks @Narsil!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13381
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.