Add generate kwargs to Seq2SeqTrainingArguments #13339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LysandreJik
approved these changes
Aug 31, 2021
Comment on lines
44
to
57
| generate_max_length: Optional[int] = field( | ||
| default=None, | ||
| metadata={ | ||
| "help": "The `max_length` to use on each evaluation loop when `predict_with_generate=True`. Will default " | ||
| "to the `max_length` value of the model configuration." | ||
| }, | ||
| ) | ||
| generate_num_beams: Optional[int] = field( | ||
| default=None, | ||
| metadata={ | ||
| "help": "The `num_beams` to use on each evaluation loop when `predict_with_generate=True`. Will default " | ||
| "to the `num_beams` value of the model configuration." | ||
| }, | ||
| ) |
There was a problem hiding this comment.
The generate_* name comes from the generate method, but for users that aren't power-users I don't think it's the best name as the verb implies an action; how about renaming to generation_max_length and generation_num_beans?
patrickvonplaten
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds two new
Seq2SeqTrainingArgumentsto control whichmax_lengthandnum_beamsare used during the intermediate evaluations of theSeq2SeqTrainer. This feature has been requested multiple times, the last in date being #13252.