Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

albert flax #13294

Merged
merged 6 commits into from Aug 30, 2021
Merged

albert flax #13294

merged 6 commits into from Aug 30, 2021

Conversation

kamalkraj
Copy link
Contributor

What does this PR do?

ALBERT Flax Model

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@LysandreJik @patrickvonplaten

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool PR @kamalkraj !!!

I think we can merge it soon. The main points to add are:

  • A slow integration test making sure that Flax gives the same results as PT for Albert
  • Add # Copied from ... statements to make sure the code is kept maintainable

@kamalkraj
Copy link
Contributor Author

@patrickvonplaten
Done changes according to your suggestions.
Thanks for the review

@stefan-it
Copy link
Collaborator

Hey @kamalkraj , thanks for that PR! Can't wait to road-test it 🤗

I tried training several ALBERT models with the official implementation, but had no luck in training a good performing model.

@kamalkraj
Copy link
Contributor Author

I tried training several ALBERT models with the official implementation, but had no luck in training a good performing model.

pre-training with TF 1 code?

@stefan-it
Copy link
Collaborator

Yeah, it was the TF 1 code base, and I've also trained various model sizes. Let's see if I have more luck using the FLAX implementation 😅

@patrickvonplaten
Copy link
Contributor

Awesome addition @kamalkraj - thanks a lot :-) Left a couple of final additions

@kamalkraj
Copy link
Contributor Author

@patrickvonplaten
Done changes according to review.

@patrickvonplaten
Copy link
Contributor

Slow tests are passing on CPU - thanks for the model addition @kamalkraj !

@patrickvonplaten patrickvonplaten merged commit 98e409a into huggingface:master Aug 30, 2021
@kamalkraj kamalkraj deleted the albert_flax branch September 11, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants