New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
albert flax #13294
albert flax #13294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool PR @kamalkraj !!!
I think we can merge it soon. The main points to add are:
- A slow integration test making sure that Flax gives the same results as PT for Albert
- Add
# Copied from ...
statements to make sure the code is kept maintainable
@patrickvonplaten |
Hey @kamalkraj , thanks for that PR! Can't wait to road-test it 🤗 I tried training several ALBERT models with the official implementation, but had no luck in training a good performing model. |
pre-training with TF 1 code? |
Yeah, it was the TF 1 code base, and I've also trained various model sizes. Let's see if I have more luck using the FLAX implementation 😅 |
Awesome addition @kamalkraj - thanks a lot :-) Left a couple of final additions |
@patrickvonplaten |
Slow tests are passing on CPU - thanks for the model addition @kamalkraj ! |
What does this PR do?
ALBERT Flax Model
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@LysandreJik @patrickvonplaten