Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of left-padded inputs #877

Open
njhill opened this issue Mar 10, 2023 · 1 comment
Open

Proper handling of left-padded inputs #877

njhill opened this issue Mar 10, 2023 · 1 comment

Comments

@njhill
Copy link

njhill commented Mar 10, 2023

At least for some models including Codegen, I'm observing very inconsistent outputs using ORTModelForCausalLM when the same inputs have different amounts of left padding (but correct corresponding attention mask). In other words an equivalent problem to the one with vanilla transformers reported in huggingface/transformers#21080 and with fixes in huggingface/transformers#21853 and huggingface/transformers#22069.

This comment alludes to something w.r.t. handling of position_ids which I was wondering might be related.

@fxmarty
Copy link
Collaborator

fxmarty commented Mar 11, 2023

Thank you for the report, will have a look shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants