MNT enable preview on black #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
No strong opinion from my side, but I usually like cross-library consistency if possible, but we already diverged in line length if I recall correctly (we use 88 here (default) vs transformers which uses 119), so really no strong opinion. |
LysandreJik
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
I think this is fine. The fact that the same black version is used across all our libraries and that make style in all repositories results in correct styling across repositories is what's important in my opinion.
No problem for me to have a specific configuration here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--previewtoblackwhich handles strings much nicer.cc @LysandreJik @osanseviero