Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs review #818

Closed
4 of 5 tasks
stevhliu opened this issue Apr 4, 2022 · 6 comments
Closed
4 of 5 tasks

Docs review #818

stevhliu opened this issue Apr 4, 2022 · 6 comments
Labels
documentation Improvements or additions to documentation

Comments

@stevhliu
Copy link
Member

stevhliu commented Apr 4, 2022

This issue shares some feedback about the latest docs. Really interesting to come back and see what I had written a couple of months ago, let me know what you think! 馃槄

  1. I think the How to integrate upstream/downstream utilities in your library docs describe the download/upload functions themselves more than they describe how-to integrate these functions into a third-party library. The titles and introductions to these docs should be updated to reflect this. It would be more accurate/clear to say something like:

Here are some functions you can use to download or upload files to and from the Hub. You can integrate these functions into your library or use them as-is.

  1. For How to integrate upstream utilities in your library, I think this would be better as two separate docs. It's not immediately clear what upstream utilities refer to which could make it difficult for users to find what they're looking for. The doc is also about more than just uploading files to the Hub. Instead, maybe we can have:
  • A How to create and manage a repository page to describe how to create, delete, and change repository visibility with huggingface_hub.
  • A How to work with repositories and files page to describe the Git-like commands (clone, branch, pull, etc.) methods with the Repository class.
  1. Instead of linking to the guide for how to integrate third-party libraries with the Hub, we should have a page in the docs dedicated to it since it is quite important. In general, I think this guide could also be updated because it's not really obvious how to do the actual integration part, except for setting up the Inference API section. There aren't clear steps for how to integrate something like snapshot_download into a third-party library.

    It would be nice to pick a library - spaCy for example - and do a walkthrough on how they integrated huggingface_hub into their library. The catch is spaCy's integration may not be generalizable to all libraries. But I think at least showing this integration process would be really helpful.

A few general housekeeping things I noticed:

  1. Link functions to the API reference by using the appropriate format: [hf_hub_url].
  2. Wrap some of the code outputs with ``` in Searching the Hub doc.

To do

cc @LysandreJik @osanseviero

@stevhliu stevhliu added the documentation Improvements or additions to documentation label Apr 4, 2022
@osanseviero
Copy link
Member

Also cc @NimaBoscarino. For context, this is about huggingface_hub docs, not the Hub docs.

@stevhliu
Copy link
Member Author

Opened #839 to take care of the general maintenance things. Next up, I'll work on something to address 1 and 2 :)

@stevhliu stevhliu mentioned this issue Apr 15, 2022
1 task
@stevhliu
Copy link
Member Author

Hi sorry for all these PRs! 馃槄 The plan moving forward is to:

  1. Merge the how-to guides.
  2. Merge the quick-start guide.
  3. Merge the updated landing page with links to all of the above.

For the third-party library integration guide, I don't think doing a step-by-step walkthrough really makes sense anymore because it is so specific to what/how the developer wants to do it. For example, the spaCy push integration looks quite different from the allennlp push integration (at least to my untrained eyes lol). As mentioned in #824, there are two ways to integrate a third-party library and we should center the guides around these:

  • Implementing internally in their own library.
  • Implementing externally in a separate library.

@osanseviero
Copy link
Member

I think the integration part also comes with product changes, so I think we can document this better in the new hub docs revamp, with links to huggingface_hub for pointers in how to do technical things.

@Wauplin
Copy link
Contributor

Wauplin commented Jun 29, 2023

@stevhliu I'm doing a bit of cleaning in the documentation issues in the repo. I believe all the points in the issue have been addressed. Especially the last point "rewrite integration guide" has been done in #1362 (see guide). Ok for you to close this one?

@stevhliu
Copy link
Member Author

Yeah thanks so much for all the work you've done! 馃コ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants