Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section about deprecation of script-based datasets? #1257

Open
severo opened this issue Mar 26, 2024 · 3 comments
Open

Add section about deprecation of script-based datasets? #1257

severo opened this issue Mar 26, 2024 · 3 comments
Labels
question Further information is requested

Comments

@severo
Copy link
Contributor

severo commented Mar 26, 2024

Asked here: huggingface/dataset-viewer#2385 (comment)

Perhaps a little bit of suggestion from me is to include a disclaimer in the docs so that others are aware that developing a custom script is not supported.

It would also help answer the discussions + we could link in the error message directly.


On the other hand, maybe we just want to deprecate it sooner than later, and not spend too much time on this.

@severo severo added the question Further information is requested label Mar 26, 2024
@severo
Copy link
Contributor Author

severo commented Mar 26, 2024

cc @lhoestq ?

@lhoestq
Copy link
Member

lhoestq commented Mar 26, 2024

They're not "deprecated" since we'll keep supporting them in datasets, they're rather "unsupported for the Viewer".

Maybe we should mention it here ? https://huggingface.co/docs/hub/datasets-viewer

@julien-c
Copy link
Member

for me if you require TRUST_REMOTE_CODE=true it's kinda deprecating script-based datasets no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants