Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter indices when batched #5113

Merged
merged 3 commits into from Oct 14, 2022

Conversation

albertvillanova
Copy link
Member

This PR fixes a bug introduced by:

Fix #5112.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 14, 2022

The documentation is not available anymore as the PR was closed or merged.

@albertvillanova
Copy link
Member Author

I think a patch release will be necessary.

@lhoestq
Copy link
Member

lhoestq commented Oct 14, 2022

I'm also fixing #5111 which will lalso require a patch release

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thank you !

@lhoestq lhoestq mentioned this pull request Oct 14, 2022
2 tasks
@albertvillanova albertvillanova merged commit d60f5ff into huggingface:main Oct 14, 2022
@albertvillanova albertvillanova deleted the fix-5112 branch October 14, 2022 12:11
@huggingface huggingface deleted a comment from pepeillo21 Oct 24, 2022
@huggingface huggingface deleted a comment from pepeillo21 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with filtered indices
3 participants