Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert task removal in folder-based builders #5051

Merged
merged 5 commits into from Oct 3, 2022

Conversation

mariosasko
Copy link
Contributor

@mariosasko mariosasko commented Sep 30, 2022

Reverts the removal of task_templates in the folder-based builders. I also added the AudioClassifaction task for consistency.

This is needed to fix huggingface/transformers#19177.

I think we should soon deprecate and remove the current task API (and investigate if it's possible to integrate the train eval index API), but we need to update the Transformers examples before that so we don't break them.

cc @NielsRogge

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 30, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks :)

I agree it would be nice to use the train_eval_index metadata in the future

@mariosasko mariosasko merged commit 583bb7d into main Oct 3, 2022
@mariosasko mariosasko deleted the revert-task-removal-folder-builders branch October 3, 2022 12:21
lhoestq pushed a commit that referenced this pull request Oct 5, 2022
* Add AudioClassification task

* Add classification task to folder based builders

* Fix tests

* Minor fix

* Minor fix again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: Task image-classification is not compatible with this dataset! Available tasks: []
3 participants