Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch CI_HUB_TOKEN_PATH with Path instead of str #5026

Merged
merged 2 commits into from Sep 26, 2022

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Sep 26, 2022

Should fix the tests for huggingface_hub==0.10.0rc0 prerelease (see failed CI).
Related to this thread (internal link).

Note: this should be a backward compatible fix (e.g. works also with previous versions of huggingface_hub)

I am not sure where to put the changes so feel free to cherry-pick the commit and close this one without merging.

cc @lhoestq

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks ! Sorry I didn't spot it ;)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 26, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq lhoestq merged commit 6a91e94 into main Sep 26, 2022
@lhoestq lhoestq deleted the fix-hffolder-for-hfh-prerelease branch September 26, 2022 14:28
lhoestq pushed a commit that referenced this pull request Oct 5, 2022
* patch CI_HUB_TOKEN_PATH with Path instead of str

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants