Revert input_columns change #5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1362,14 +1362,12 @@ def test_map_input_columns(self, in_memory): | |||
| with tempfile.TemporaryDirectory() as tmp_dir: | |||
| with self._create_dummy_dataset(in_memory, tmp_dir, multiple_columns=True) as dset: | |||
| with dset.map(lambda col_1: {"label": col_1 % 2}, input_columns="col_1") as mapped_dset: | |||
| self.assertEqual(mapped_dset[0].keys(), {"col_1", "col_2", "col_3", "label"}) | |||
| self.assertEqual(mapped_dset[0].keys(), {"col_1", "label"}) | |||
There was a problem hiding this comment.
Why don't you remove completely the test test_map_input_columns, introduced in #4971?
There was a problem hiding this comment.
Unfortunately input_columns wasn't tested before this PR, so I think it's nice to keep this test, but with the correct behavior (i.e. don't keep all the columns)
|
The documentation is not available anymore as the PR was closed or merged. |
|
Merging this one and I'll check if it fixes the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #4971
Fix #5005