Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IterableDataset.from_generator to the API #4988

Closed
mariosasko opened this issue Sep 16, 2022 · 3 comments · Fixed by #5052
Closed

Add IterableDataset.from_generator to the API #4988

mariosasko opened this issue Sep 16, 2022 · 3 comments · Fixed by #5052
Assignees
@hamid-vakilzadeh
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mariosasko
Copy link
Collaborator

We've just added Dataset.from_generator to the API. It would also be cool to add IterableDataset.from_generator to support creating an iterable dataset from a generator.

cc @lhoestq
@mariosasko mariosasko added enhancement New feature or request good first issue Good for newcomers labels Sep 16, 2022
@hamid-vakilzadeh
Copy link
Contributor

#take

@lhoestq
Copy link
Member

lhoestq commented Sep 20, 2022

Thanks @hamid-vakilzadeh ! Let us know if you have some questions or if we can help

@hamid-vakilzadeh
Copy link
Contributor

Thank you! I certainly will reach out if I need any help.

@hamid-vakilzadeh hamid-vakilzadeh mentioned this issue Sep 30, 2022
Merged
@mariosasko mariosasko linked a pull request Oct 3, 2022 that will close this issue
added from_generator method to IterableDataset class. #5052
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamid-vakilzadeh hamid-vakilzadeh

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added from_generator method to IterableDataset class. hamid-vakilzadeh/datasets
3 participants
@lhoestq @mariosasko @hamid-vakilzadeh