-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run /metrics on another port #273
Comments
Note that one issue is that we want to get metrics about the main app using the PrometheusMiddleware (https://github.com/huggingface/datasets-server/blob/cc763a31d588b88ce56a0ac6eccc6fd923a8a9eb/services/api/src/api/app.py#L48). Running the |
An option is to rewrite the Another one is to setup the reverse proxy. |
See a report from hackerone here: #496 |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
not needed anymore (at least for now). Maybe take into account if we migrate to node (#493) |
See #260 (comment)
See also how it's done in Go for the tensorboard launcher: https://github.com/huggingface/tensorboard-launcher/blob/46df45821e8311095e824bc39b9acdadaf99634c/launcher/pkg/cmd/launcher/main.go#L61
The text was updated successfully, but these errors were encountered: