Better check for deepspeed availability #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
approved these changes
May 20, 2022
src/accelerate/utils/imports.py
Outdated
| # AND checking it has an author field in the metadata that is HuggingFace. | ||
| if package_exists: | ||
| try: | ||
| _ = importlib_metadata.version("deepspeed") |
There was a problem hiding this comment.
Suggested change
| _ = importlib_metadata.version("deepspeed") |
If I'm not mistaken this is unnecessary. You can do _deepspeed_metadata.get("version") if it's needed?
There was a problem hiding this comment.
importlib_metadata.metadata will also then raise the same error if it's not installed
|
The documentation is not available anymore as the PR was closed or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having issues in the tests of Transformers where there is a folder called
deepspeedcontaining test files for DeepSpeed.That folder gets interpreted as the "DeepSpeed" package by Accelerate, which then tries to import things.
This PR fixes that by making the test for
deepspeedmore robust (like we have for Datasets in Transformers).