Refactor tests to use accelerate launch #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
May 19, 2022
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tests to use accelerate launch
What does this add?
This PR refactors all the example tests to use
accelerate launchto be ran, adjusting any testing logic that needs to be done to compensate for this. Mostly changing the accelerate.print mocks to use string matching instead based on stdout fromsubprocess.runWhy is it needed?
In order to have our tests be ran on more than one GPU, the tests needed to be refactored to allow for the
accelerate launchcommand to be used via subprocess rather than calling it in python directly.What parts of the API does this impact?
User-facing:
All of the example scripts now contain a small snippet denoting that a particular import is only used for testing, and should be ignored
Internal structure:
mocked_dataloaderswas migrated to the test utils.