fix tracking #361
Merged
fix tracking #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
reviewed
May 12, 2022
| @@ -293,7 +294,7 @@ def collate_fn(examples): | |||
| { | |||
| "accuracy": eval_metric["accuracy"], | |||
| "f1": eval_metric["f1"], | |||
| "train_loss": total_loss, | |||
| "train_loss": total_loss.item() if type(total_loss) == torch.Tensor else total_loss, | |||
There was a problem hiding this comment.
Do we really have either a Tensor or something else? Can't it always be .item() here?
examples/by_feature/tracking.py
Outdated
| if args.with_tracking: | ||
| accelerator.log( | ||
| { | ||
| "accuracy": eval_metric["accuracy"], | ||
| "f1": eval_metric["f1"], | ||
| "train_loss": total_loss, | ||
| "train_loss": total_loss.item() if type(total_loss) == torch.Tensor else total_loss, |
examples/complete_nlp_example.py
Outdated
| @@ -245,9 +246,10 @@ def collate_fn(examples): | |||
| { | |||
| "accuracy": eval_metric["accuracy"], | |||
| "f1": eval_metric["f1"], | |||
| "train_loss": total_loss, | |||
| "train_loss": total_loss.item() if type(total_loss) == torch.Tensor else total_loss, | |||
|
Oh, also make sure to edit the title of the PR ;-) |
muellerzr
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
log_others. No plots were being created. Fixing it to be able to get plots for metrics usinglog_metricandlog_metrics.Post these changes, below are the plots for the run_glue_no_trainer.py script on MRPC task using all trackers.
