Deprecation and test cleanup #1818
Merged
+28
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1818 +/- ##
==========================================
+ Coverage 92.05% 92.15% +0.09%
==========================================
Files 23 23
Lines 2342 2307 -35
Branches 435 425 -10
==========================================
- Hits 2156 2126 -30
+ Misses 143 141 -2
+ Partials 43 40 -3
Continue to review full report at Codecov.
|
|
Tagging for 20.3. |
yunstanford
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
app.remove_routeandrequest.raw_argsthat have been deprecated for a long time. Fix all warnings in tests (mainly asyncio py36 vs. py38 incompatibility). On py38 we'll need the next yet unreleased version websockets>8.1 to get rid of the few remaining deprecated loop warnings.