From b48b6174a46391f43ae9ac5a8e239f4673928ca1 Mon Sep 17 00:00:00 2001 From: Karthikeyan Annamalai Date: Sun, 28 Aug 2022 12:09:58 +0530 Subject: [PATCH 1/2] Fixing NPE while the current page is empty https://github.com/hub4j/github-api/issues/1503 --- src/main/java/org/kohsuke/github/PagedIterator.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/kohsuke/github/PagedIterator.java b/src/main/java/org/kohsuke/github/PagedIterator.java index 801a0b8fab..6fa0d10d3b 100644 --- a/src/main/java/org/kohsuke/github/PagedIterator.java +++ b/src/main/java/org/kohsuke/github/PagedIterator.java @@ -72,7 +72,8 @@ protected void wrapUp(T[] page) { */ public boolean hasNext() { fetch(); - return currentPage.length > nextItemIndex; + //https://github.com/hub4j/github-api/issues/1503 + return (currentPage != null && currentPage.length > nextItemIndex); } /** From 7b6c3265f0415e156bcd428eebc8f5ce2f0c956b Mon Sep 17 00:00:00 2001 From: Liam Newman Date: Thu, 1 Sep 2022 23:07:41 -0700 Subject: [PATCH 2/2] Update src/main/java/org/kohsuke/github/PagedIterator.java --- src/main/java/org/kohsuke/github/PagedIterator.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/org/kohsuke/github/PagedIterator.java b/src/main/java/org/kohsuke/github/PagedIterator.java index 6fa0d10d3b..9f3b4952b9 100644 --- a/src/main/java/org/kohsuke/github/PagedIterator.java +++ b/src/main/java/org/kohsuke/github/PagedIterator.java @@ -72,7 +72,6 @@ protected void wrapUp(T[] page) { */ public boolean hasNext() { fetch(); - //https://github.com/hub4j/github-api/issues/1503 return (currentPage != null && currentPage.length > nextItemIndex); }