Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Consider squash merges instead of rebase #1738

Open
Haarolean opened this issue Nov 9, 2023 · 1 comment
Open

Meta: Consider squash merges instead of rebase #1738

Haarolean opened this issue Nov 9, 2023 · 1 comment
Labels

Comments

@Haarolean
Copy link
Contributor

Hi!

Just a minor issue I've observed while scanning the git log, it seems that current PR merges into the master are being done via rebase strategy.
I wanted to propose considering switching to a squash strategy, with that there won't be multiple commits for a single PR, which can be distracting.
Like it is now:
image
Plus this commit:
image

With squash, there would be just one commit like the second one.

@bitwiseman
Copy link
Member

Hm. I'm not a fan of squash merges, but I'm open to the idea. I could try changing the default for the repo and see what it looks like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants