Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outside_collaborators list #1561

Merged
merged 5 commits into from Nov 12, 2022

Conversation

Diegunix
Copy link
Contributor

@Diegunix Diegunix commented Nov 8, 2022

Description

This PR adds the ability to list outside members of the organization.
As indicated in the github documentation (https://docs.github.com/en/rest/orgs/outside-collaborators)

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests please.

@Diegunix
Copy link
Contributor Author

Diegunix commented Nov 9, 2022

Add tests please.

DONE

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 79.27% // Head: 79.29% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (2aaef51) compared to base (838b82a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1561      +/-   ##
============================================
+ Coverage     79.27%   79.29%   +0.02%     
- Complexity     2137     2140       +3     
============================================
  Files           206      206              
  Lines          6562     6564       +2     
  Branches        362      362              
============================================
+ Hits           5202     5205       +3     
+ Misses         1148     1147       -1     
  Partials        212      212              
Impacted Files Coverage Δ
...c/main/java/org/kohsuke/github/GHOrganization.java 68.21% <100.00%> (+1.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little more testing and I'll merge. Thanks for contributing!

@bitwiseman bitwiseman merged commit 045294d into hub4j:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants